Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:dynamic wallet selection #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SarveshLimaye
Copy link

@SarveshLimaye SarveshLimaye commented Nov 28, 2024

  • Implemented dynamic wallet selection for executing CLI commands, enhancing flexibility and simplifying multi-wallet management.

  • Balance

Screenshot 2024-11-28 at 11 06 32 PM

Screenshot 2024-11-28 at 11 07 12 PM

  • Transfer

Screenshot 2024-11-28 at 11 10 01 PM

  • Bridge

Screenshot 2024-11-28 at 11 15 20 PM

Copy link
Collaborator

@ezequiel-rodriguez ezequiel-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review the comments. TY

src/commands/balance.ts Outdated Show resolved Hide resolved
src/commands/transfer.ts Outdated Show resolved Hide resolved
src/utils/viemProvider.ts Outdated Show resolved Hide resolved
@SarveshLimaye
Copy link
Author

SarveshLimaye commented Nov 30, 2024

@ezequiel-rodriguez Thank you so much for the review. The suggestions above make total sense, and I’ve implemented all the changes recommended. Please let me know if any further changes are required.

Thank you

@chrisarevalodev
Copy link
Collaborator

LGTM

Copy link
Collaborator

@ezequiel-rodriguez ezequiel-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SarveshLimaye
Copy link
Author

Thanks for the review @ezequiel-rodriguez @chrisarevalodev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants