Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests #318

Open
yihui opened this issue Jul 27, 2018 · 5 comments
Open

Add more unit tests #318

yihui opened this issue Jul 27, 2018 · 5 comments
Labels
help wanted ❤️ we'd love your help!

Comments

@yihui
Copy link
Member

yihui commented Jul 27, 2018

@novica
Copy link
Contributor

novica commented Aug 18, 2019

I started writing some tests.

By stared I mean I have a testit that passes different strings to quote_poem() and it seems to be working.

However, I immediately got stuck at quote_poem_addin(). I'm having hard time figuring out how to test a function that talks to the rstudio api. I would appreciate some guidance here.

@yihui
Copy link
Member Author

yihui commented Aug 19, 2019

No need to test quote_poem_addin(). Testing quote_poem() will be enough and it is the essential function behind the addin. Thank you very much!

@novica
Copy link
Contributor

novica commented Aug 19, 2019

OK. I will make a pull request with the test for quote_poem(). I don't think I can do anything with the rest of the functions in addin.R.

@novica
Copy link
Contributor

novica commented Aug 22, 2019

Moving onto clean.R, I am thinking to separate the functions so that I only test the string manipulations, and not the opening and writing of the file. Does this make sense?

@yihui
Copy link
Member Author

yihui commented Aug 22, 2019

Yes.

@cderv cderv added help wanted ❤️ we'd love your help! and removed help wanted labels Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted ❤️ we'd love your help!
Projects
None yet
Development

No branches or pull requests

3 participants