add: verifyInputMessage for mock-session #3791
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Proof of concept"
Added methods to
mock-session
for verifying that specific calls tosession$sendInputMessage
were performed. Note: Before merging, these methods should be expanded to includesession$sendCustomMessage
andsession$sendBinaryMessage
!This suggestion is inspired by how mocked classes in C# with Moq behave; that the mock itself is able to verify whether a given call was performed. By allowing
mock-session
to verify (upon request, naturally) it makes it easier to write unit tests of Shiny update methods, as the developer doesn't have to write boilerplate code. See e.g. following examples fromtests/testthat/test-update-input.R
:Before:
After:
The
verifyInputMessage
has built-in support for thetestthat
-package, without depending on it. CallingverifyInputMessage
is enough in atest_that
:Before:
After (with actual testing):
As noted initially, these methods should be implemented for
sendCustomMessage
andsendBinaryMessage
before including, and I will gladly do this (letting the three methods use the same routine, somehow).