-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider switching to tinyglobby #646
Comments
Oh, thanks for the heads up! So elm-test 0.19.1-revision13 is broken for Node.js 10–18 now (using the default npm that ships with those Node.js versions), fml 😵 |
Because of npm/npm-pick-manifest#33. Thanks to @lishaduck for reporting this (#646). This is a quick-fix. That issue mentions switching to tinyglobby. That’s a better long term solution.
I did a quick-fix for now, restoring Node.js 14–18 support. Node.js 12 is still broken. Switching to tinyglobby sounds great, but isn’t something I want to spend time on right now. |
From what I can see, it's broken (at least) because of |
It supports down through node12, is faster (allegedly), has a nicer API (subjectively), and is what elm-review uses nowadays.
Oh, and b/c npm/npm-pick-manifest#33 didn't land until npm 10.8.2 (node 22.5.0), you'll ideally not want to depend on multiple versions of glob (elm-review hit this), so tinyglobby also helps there (meaning the workarounds from #639 are unneeded).
The text was updated successfully, but these errors were encountered: