Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to tinyglobby #646

Open
lishaduck opened this issue Feb 15, 2025 · 3 comments · May be fixed by #647
Open

Consider switching to tinyglobby #646

lishaduck opened this issue Feb 15, 2025 · 3 comments · May be fixed by #647

Comments

@lishaduck
Copy link

lishaduck commented Feb 15, 2025

It supports down through node12, is faster (allegedly), has a nicer API (subjectively), and is what elm-review uses nowadays.
Oh, and b/c npm/npm-pick-manifest#33 didn't land until npm 10.8.2 (node 22.5.0), you'll ideally not want to depend on multiple versions of glob (elm-review hit this), so tinyglobby also helps there (meaning the workarounds from #639 are unneeded).

@lydell
Copy link
Collaborator

lydell commented Feb 15, 2025

Oh, thanks for the heads up! So elm-test 0.19.1-revision13 is broken for Node.js 10–18 now (using the default npm that ships with those Node.js versions), fml 😵

lydell added a commit that referenced this issue Feb 15, 2025
Because of npm/npm-pick-manifest#33.

Thanks to @lishaduck for reporting this (#646).

This is a quick-fix. That issue mentions switching to tinyglobby. That’s
a better long term solution.
@lydell
Copy link
Collaborator

lydell commented Feb 15, 2025

I did a quick-fix for now, restoring Node.js 14–18 support. Node.js 12 is still broken.

Switching to tinyglobby sounds great, but isn’t something I want to spend time on right now.

@jfmengels
Copy link
Contributor

From what I can see, it's broken (at least) because of minimatch v9 being used, which only supports 14 and up. minimatch is used because glob@10, so switching to tinyglobby (v12 and up) might be a good solution to the problem actually.

@jfmengels jfmengels linked a pull request Feb 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants