Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add buildsystems example cxx #552

Closed

Conversation

lulivi
Copy link
Collaborator

@lulivi lulivi commented Nov 4, 2022

Summary

Fix #551

Details and comments

Create and fix some issues in the build_systems example.

Checks

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added a new C/C++ example and updated examples/connext_dds/CMakeList.txt accordingly.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

The compilation is starting. Take a look here.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Oops, something went wrong!

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

The compilation is starting. Take a look here.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Oops, something went wrong!

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

The compilation is starting. Take a look here.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Everything is OK. Thank you for the PR!

@alexcamposruiz
Copy link
Contributor

Add README.md to top-level directory explaining the purpose of the example and pointing to the /README.md for details.

@alexcamposruiz
Copy link
Contributor

A c++11 example should have priority over c++98 or c.

Copy link
Contributor

@alexcamposruiz alexcamposruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple comments.

@alexcamposruiz
Copy link
Contributor

This PR hasn't been updated in a long time. Feel free to update and reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Create a c++98 build_systems example
2 participants