Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git step should support authentication #58

Open
rtyler opened this issue Dec 1, 2020 · 0 comments
Open

git step should support authentication #58

rtyler opened this issue Dec 1, 2020 · 0 comments
Labels
component/stdlib Step standard library issues enhancement New feature or request

Comments

@rtyler
Copy link
Owner

rtyler commented Dec 1, 2020

Right now the git step doesn't have any means of authenticating for its clones.

This is unfortunately because the credentials subsystem hasn't yet been plumbed out for Otto yet.
@rtyler rtyler added enhancement New feature or request component/stdlib Step standard library issues labels Dec 1, 2020
@rtyler rtyler mentioned this issue Dec 1, 2020
Open
nakulpathak3 added a commit to nakulpathak3/otto that referenced this issue Dec 12, 2020
@nakulpathak3
Add multi-line comment support to parser
0421bf7 
Copied this straight from Pest itself so must be right 😅
https://github.com/pest-parser/pest/pull/332/files

Fixes rtyler#58
nakulpathak3 added a commit to nakulpathak3/otto that referenced this issue Dec 12, 2020
@nakulpathak3
Add multi-line comment support to parser
4c32a10 
Copied this straight from Pest itself so must be right 😅
https://github.com/pest-parser/pest/pull/332/files

Tested against
```
/* 1-line multiline comment */

/*
  N-line multiline comment
*/

/*
  // Line comment inside multiline
  /*
    (Multiline inside) multiline
  */

*/
```

Testing steps -
* `cargo build`
* `make run`
* `scripts/local-run` with above inputs

Fixes rtyler#58
@nakulpathak3 nakulpathak3 mentioned this issue Dec 12, 2020
Merged
nakulpathak3 added a commit to nakulpathak3/otto that referenced this issue Dec 12, 2020
@nakulpathak3
Add multi-line comment support to parser
1fa3f11 
Copied this straight from Pest itself so must be right 😅
https://github.com/pest-parser/pest/pull/332/files

Tested against
```
/* 1-line multiline comment */

/*
  N-line multiline comment
*/

/*
  // Line comment inside multiline
  /*
    (Multiline inside) multiline
  */

*/
```

Testing steps -
* `cargo build`
* `make run`
* `scripts/local-run` with above inputs

Fixes rtyler#58
nakulpathak3 added a commit to nakulpathak3/otto that referenced this issue Dec 12, 2020
@nakulpathak3
Add multi-line comment support to parser
36c2c4c 
Copied this straight from Pest itself so must be right 😅
https://github.com/pest-parser/pest/pull/332/files

Tested against
```
/* 1-line multiline comment */

/*
  N-line multiline comment
*/

/*
  // Line comment inside multiline
  /*
    (Multiline inside) multiline
  */

*/
```

Testing steps -
* `cargo build`
* `make run`
* `scripts/local-run` with above inputs

Fixes rtyler#58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/stdlib Step standard library issues enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rtyler