Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Flagger on localhost by default #2

Open
emersion opened this issue Sep 20, 2013 · 4 comments
Open

Disable Flagger on localhost by default #2

emersion opened this issue Sep 20, 2013 · 4 comments

Comments

@emersion
Copy link

Enabling Flagger on localhost or 172.0.0.1 makes no sense. Is it possible to disable it ?

@rubbingalcoholic
Copy link
Owner

I would like to add a server white-list feature, which you could use to add exceptions to the URL rewriting. The thing about being smart and trying to filter these universally is that it would slow things down (this has to run on every outgoing HTTP request) so checking against a list for every outbound URL would be a performance hog.

@emersion
Copy link
Author

How about a switch to enable/disable filtering (and a warning message when enabling it) ?

@rubbingalcoholic
Copy link
Owner

Yes. This is a good idea. I would like to add this for the next release.

@emersion
Copy link
Author

Thank you for your good work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants