From 143e31058cd05bcb2edaaae14a10d3cf2a36af3f Mon Sep 17 00:00:00 2001
From: Gijs Weterings <gweterings@meta.com>
Date: Fri, 10 May 2024 09:38:34 -0700
Subject: [PATCH] Fix
xplat/endtoend/jest-e2e/apps/facebook_xplat/ReactNativeCoreE2E/__tests__/Border-corner-radii-elevation-percentages-e2e.js
to actually use the right example (#44525)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/44525
These examples were added, but their names were duplicated. This caused our internal e2e tests to accidentally target the wrong examples.
Changelog:
[General][Fixed] RNTester examples for border percentages are now properly covered by E2E screenshot tests.
Reviewed By: NickGerleman
Differential Revision: D57207306
fbshipit-source-id: 32ed5cc6b136a8928b11afe8b824c752edcdd9e5
---
.../js/examples/Border/BorderExample.js | 16 ++++++++--------
.../rn-tester/js/examples/View/ViewExample.js | 2 +-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/packages/rn-tester/js/examples/Border/BorderExample.js b/packages/rn-tester/js/examples/Border/BorderExample.js
index 653509fca70a8d..12e9a08c3e3422 100644
--- a/packages/rn-tester/js/examples/Border/BorderExample.js
+++ b/packages/rn-tester/js/examples/Border/BorderExample.js
@@ -126,9 +126,9 @@ const styles = StyleSheet.create({
},
border9Percentages: {
borderWidth: 10,
- borderTopLeftRadius: '10%',
- borderBottomRightRadius: '20%',
- borderColor: 'black',
+ borderTopLeftRadius: '20%',
+ borderBottomRightRadius: '10%',
+ borderColor: 'red',
},
border10: {
borderWidth: 10,
@@ -141,9 +141,9 @@ const styles = StyleSheet.create({
border10Percentages: {
borderWidth: 10,
backgroundColor: 'white',
- borderTopLeftRadius: '10%',
- borderBottomRightRadius: '20%',
- borderColor: 'black',
+ borderTopLeftRadius: '20%',
+ borderBottomRightRadius: '10%',
+ borderColor: 'red',
elevation: 10,
},
border11: {
@@ -359,7 +359,7 @@ export default ({
},
{
title: 'Corner Radii (Percentages)',
- name: 'corner-radii',
+ name: 'corner-radii-percentages',
description: 'borderTopLeftRadius & borderBottomRightRadius',
render: function (): React.Node {
return (
@@ -386,7 +386,7 @@ export default ({
},
{
title: 'Corner Radii / Elevation (Percentages)',
- name: 'corner-radii-elevation',
+ name: 'corner-radii-elevation-percentages',
description: 'borderTopLeftRadius & borderBottomRightRadius & elevation',
platform: 'android',
render: function (): React.Node {
diff --git a/packages/rn-tester/js/examples/View/ViewExample.js b/packages/rn-tester/js/examples/View/ViewExample.js
index 9044ef9a621bfa..1f8d917b29aae4 100644
--- a/packages/rn-tester/js/examples/View/ViewExample.js
+++ b/packages/rn-tester/js/examples/View/ViewExample.js
@@ -649,7 +649,7 @@ export default ({
},
{
title: 'Rounded Borders (Percentages)',
- name: 'rounded-borders-percentage',
+ name: 'rounded-borders-percentages',
render(): React.Node {
return (
<View