Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase content-type and x-cascade headers #2356

Closed
wants to merge 1 commit into from

Conversation

schinery
Copy link
Contributor

Questions:

  • The files spec/grape/entity_spec.rb and spec/grape/middleware/formatter_spec.rb has specs testing for Content-type, should these be lower case?

@grape-bot
Copy link

1 Warning
⚠️ Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#2356](https://github.com/ruby-grape/grape/pull/2356): Lowercase content-type and x-cascade headers - [@schinery](https://github.com/schinery).

Generated by 🚫 Danger

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schinery There's likely a lot of people relying on the fact that these headers are capitalized the way they are in Grape. I am 100% sure I've written code like that. In the original issue you say "The X-Cascade header in Rack 3 applications appears to need to be lower case..." - can you please help find the source of that and why it was changed? If it's an RFC of some kind then we can convince ourselves it's the right change.

@schinery
Copy link
Contributor Author

Closing as #2355 seems to be the preferred approach

@schinery schinery closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants