From ef5b0caa6b3bb9b5a34c76a668fd71cc2669a9ab Mon Sep 17 00:00:00 2001 From: Kevin Newton Date: Thu, 3 Oct 2024 09:13:26 -0400 Subject: [PATCH] Fix up node RBI typechecks --- templates/rbi/prism/node.rbi.erb | 5 ++--- templates/sig/prism/node.rbs.erb | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/templates/rbi/prism/node.rbi.erb b/templates/rbi/prism/node.rbi.erb index b3bc8b93754..c0474bd2089 100644 --- a/templates/rbi/prism/node.rbi.erb +++ b/templates/rbi/prism/node.rbi.erb @@ -81,11 +81,11 @@ end class Prism::<%= node.name -%> < Prism::Node <%- if (node_flags = node.flags) -%> <%- node_flags.values.each do |value| -%> - sig { returns(T::Boolean) } def <%= value.name.downcase %>?; end - <%- end -%> + <%- end -%> + <%- end -%> <%- node.fields.each do |field| -%> sig { returns(<%= field.rbi_class %>) } def <%= field.name %>; end @@ -130,7 +130,6 @@ class Prism::<%= node.name -%> < Prism::Node def <%= field.name.delete_suffix("_loc") %>; end <%- end -%> <%- end -%> - <%- end -%> sig { override.returns(T::Array[Prism::Reflection::Field]) } def fields; end diff --git a/templates/sig/prism/node.rbs.erb b/templates/sig/prism/node.rbs.erb index f7a5af21983..c8f9b86cf12 100644 --- a/templates/sig/prism/node.rbs.erb +++ b/templates/sig/prism/node.rbs.erb @@ -53,8 +53,8 @@ module Prism class <%= node.name -%> < Node include _Node <%- if (node_flags = node.flags) -%> - <%- node_flags.values.each do |value| -%> + <%- node_flags.values.each do |value| -%> def <%= value.name.downcase %>?: () -> bool <%- end -%> <%- end -%>