Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream supported dev dependency versions #593

Closed

Conversation

benlangfeld
Copy link

No description provided.

@eregon
Copy link
Member

eregon commented May 6, 2024

As mentioned in #592 (comment) we should instead remove those files (and add tests creating these files dynamically ideally, right now these files are unused), could you update the PR to do that?

@benlangfeld
Copy link
Author

These files are very much used in the local environment of a developer working on this project. I do not think dynamically generating them for CI is at all related to the concern this PR fixes.

@eregon
Copy link
Member

eregon commented May 6, 2024

That's not their purpose in this project, e.g. see https://github.com/ruby/setup-ruby/commits/master/.ruby-version https://github.com/ruby/setup-ruby/commits/master/.tool-versions
They were only added for testing, but probably these tests got removed (in e16528e).

There is no need for any particular version of these tools to work on this project, it's JS anyway.

@benlangfeld
Copy link
Author

benlangfeld commented May 6, 2024

There is no need for any particular version of these tools to work on this project, it's JS anyway.

NodeJS and Yarn are required. Ruby is useful for manipulating the example Bundler lock files used in tests, for example. Is it not preferable for these tools to be readily available to contributors at a known working version via a dependency management solution (this or Docker, for example) than to require their manual installation/selection?

@eregon
Copy link
Member

eregon commented May 6, 2024

Look, I know why I added them, the versions there are meant to test setup-ruby picking the ruby version from it, nothing else.
And I do not want to bother updating these or get noise in PRs from them.

@eregon eregon closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants