Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature parity: don't fail when untracked git files aren't in codeowners #46

Open
technicalpickles opened this issue Nov 14, 2024 · 3 comments

Comments

@technicalpickles
Copy link
Contributor

I just noticed this while testing. I had an untracked file that the ruby version is fine with, but the rust version wants to add

Ruby:

❯ bin/codeownership validate --diff
❯

Rust:

❯ bin/codeowners-rs generate-and-validate

Some files are missing ownership
- script/count-cursorignore.rb


❯
@tstannard
Copy link

@perryqh can you take a look at this? TIA!

@tstannard
Copy link

cc @jackboberg

We (modularity team) would be happy to pair on this with you too!

@perryqh
Copy link
Contributor

perryqh commented Nov 15, 2024

@tstannard is this a high priority? I'm definitely planning on fixing this and am happy to involve your team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants