Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

celluloid's leaky version misrepresented? #22

Open
etagwerker opened this issue Aug 14, 2020 · 0 comments
Open

celluloid's leaky version misrepresented? #22

etagwerker opened this issue Aug 14, 2020 · 0 comments

Comments

@etagwerker
Copy link
Contributor

Hey,

I noticed that celluloid's leaky versions are defined like this:

---
gem: celluloid
url: https://github.com/celluloid/celluloid/issues/670
title: Memory Leak using Celluloid::Future
date: 2015-08-31
description: |
  The Celluloid::Group::Spawner appears to never clean up the completed Threads
  that it creates.
leaky_versions:
  - "> 0.16.0, < 0.17.2"
patched_versions:
  - ">= 0.17.3"

Shouldn't leaky_versions say this?

leaky_versions:
  - "> 0.16.0, < 0.17.2"
patched_versions:
  - ">= 0.17.2"

The patch made it into v0.17.2 (see celluloid/celluloid@5725fee)

It seems that it is misreporting a leaky gem when you are using 0.17.2:

$ bundle leak
Name: celluloid
Version: 0.17.2
URL: https://github.com/celluloid/celluloid/issues/670
Title: Memory Leak using Celluloid::Future
Solution: upgrade to >= 0.17.3

Leaks found!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant