Skip to content

Commit

Permalink
don't run browser tests on 4 times per browser (per os and node version)
Browse files Browse the repository at this point in the history
  • Loading branch information
torokati44 committed Aug 22, 2024
1 parent 2e7a41b commit b39ceea
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions .github/workflows/test_web.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,37 +94,36 @@ jobs:
run: npm test

- name: Upload artifacts
if: matrix.os == 'ubuntu-22.04' && matrix.node_version == '22'
uses: actions/upload-artifact@v4
with:
name: web-build-${{ runner.os }}-node${{ matrix.node_version }}
path: web/packages/selfhosted/dist # TODO: maybe core too?
name: selfhosted-dist
path: web/packages/selfhosted/dist

browser-tests:
needs: build
if: needs.changes.outputs.should_run == 'true'
name: Test ${{ matrix.browser }} / Node.js ${{ matrix.node_version }} / ${{ matrix.os }}
runs-on: ${{ matrix.os }}
name: Test in ${{ matrix.browser }}
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
node_version: ["20", "22"]
os: [ubuntu-22.04, windows-latest] # TODO: Don't run browser tests on Windows because it's flaky for unknown reasons. :-(
browser: ["chrome", "firefox", "edge"]

steps:
- uses: actions/checkout@v4

- name: Setup Node.js ${{ matrix.node_version }}
- name: Setup Node.js 22
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node_version }}
node-version: 22
cache: npm
cache-dependency-path: web/package-lock.json

- name: Download artifacts
uses: actions/download-artifact@v4
with:
name: web-build-${{ runner.os }}-node${{ matrix.node_version }}
name: selfhosted-dist
path: web/packages/selfhosted/dist

- name: Run browser-based tests
Expand Down

0 comments on commit b39ceea

Please sign in to comment.