-
Notifications
You must be signed in to change notification settings - Fork 4
Pseudoelements indicating external links look weird in table #27
Comments
@TimDaub can you tell me where do you want those arrow tags? If you want them in footer so I can change it and arrow will be allowed only for footer instead of whole code base. |
OK so here's a list that might not account for what's easily achievable in CSS:
And then I also find it slightly off-putting that there seem to be two different formattings for a link in the footer and in the table. But that might already be addressed by solving #4. However, for Helvetica/Arial fonts, the marker's line height should be more accurate. Right now, the bottom-left part of the arrow is lower than the lowest part of the text statement. So we want to center the marker based on the text's line height, and I think we also want to shrink it slightly. I know those are a lot of requirements. I trust that if you take on this issue, you can align it such that it is visually pleasing for you. So I'm open to seeing proposals. |
@TimDaub no problem I will try, and see what I can do with these issues. |
btw. this task is "paid" and if you send me an offer before doing it, you can receive payment in USDC. Process is here: https://github.com/rugpullindex/documents/blob/master/handbook.md#how-to-get-an-offer-approved-to-start-working-on-rpi |
@TimDaub sure I will send you the offer but can you elaborate more about what changes you want exactly. I got a bit confused here first you said
And then you said that you want
Which means not to remove pseudoelement from whole main page table but only to some columns. |
Ok, let's do what I said here: #27 (comment) and ignore "Remove pseudoelement for main page table" |
Ok I will do what is said there!😊 |
I don't know how to frame such proposal and you give me some idea or instance. And how much offer is ideal to demand for such work!? This is first of a kind "paid" contract so have such doubts :-l |
The arrow should not appear in the table at all, only in text blocks (in the blog). Also no need to have it in the footer in my opinions, as it's clear those links are clickable. |
@florianmodel I will do whatever the updates you and @TimDaub wants . once he assign this work to me and give the answer of the above questions I asked about proposal and other things. |
Hey, can you please rply to my comments above.I really wanted to contribute here. |
You can text me in Discord to get further help. Or carefully read the handbook document. It outlines what information is necessary and where to send it. |
@TimDaub can you please provide discord channel link. I am unable to find it on this repo 🥺 |
Scope
Deliverables
Time estimate
The text was updated successfully, but these errors were encountered: