Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Pseudoelements indicating external links look weird in table #27

Open
TimDaub opened this issue Dec 3, 2021 · 14 comments
Open

Pseudoelements indicating external links look weird in table #27

TimDaub opened this issue Dec 3, 2021 · 14 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@TimDaub
Copy link
Member

TimDaub commented Dec 3, 2021

Scope

Screen Shot 2021-12-03 at 10 25 14

Screen Shot 2021-12-03 at 10 25 20

Deliverables

  • Remove pseudoelement for main page table

Time estimate

  • 1h
@TimDaub TimDaub added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Dec 3, 2021
@NAMANIND
Copy link

NAMANIND commented Dec 3, 2021

@TimDaub can you tell me where do you want those arrow tags? If you want them in footer so I can change it and arrow will be allowed only for footer instead of whole code base.

@TimDaub
Copy link
Member Author

TimDaub commented Dec 3, 2021

OK so here's a list that might not account for what's easily achievable in CSS:

  • A link text that includes a line break, e.g. "Products on \nAmazon.com" shouldn't have such a marker
  • An SVG icon like the piechart in the example should not have such a marker

And then I also find it slightly off-putting that there seem to be two different formattings for a link in the footer and in the table. But that might already be addressed by solving #4.

However, for Helvetica/Arial fonts, the marker's line height should be more accurate. Right now, the bottom-left part of the arrow is lower than the lowest part of the text statement. So we want to center the marker based on the text's line height, and I think we also want to shrink it slightly.

I know those are a lot of requirements. I trust that if you take on this issue, you can align it such that it is visually pleasing for you. So I'm open to seeing proposals.

@NAMANIND
Copy link

NAMANIND commented Dec 3, 2021

I know those are a lot of requirements.

@TimDaub no problem I will try, and see what I can do with these issues.

@TimDaub
Copy link
Member Author

TimDaub commented Dec 3, 2021

btw. this task is "paid" and if you send me an offer before doing it, you can receive payment in USDC. Process is here: https://github.com/rugpullindex/documents/blob/master/handbook.md#how-to-get-an-offer-approved-to-start-working-on-rpi

@NAMANIND
Copy link

NAMANIND commented Dec 3, 2021

@TimDaub sure I will send you the offer but can you elaborate more about what changes you want exactly. I got a bit confused here first you said

Remove pseudoelement for main page table

And then you said that you want

A link text that includes a line break, e.g. "Products on \nAmazon.com" shouldn't have such a marker

An SVG icon like the piechart in the example should not have such a marker

Which means not to remove pseudoelement from whole main page table but only to some columns.

@TimDaub
Copy link
Member Author

TimDaub commented Dec 3, 2021

Ok, let's do what I said here: #27 (comment) and ignore "Remove pseudoelement for main page table"

@NAMANIND
Copy link

NAMANIND commented Dec 3, 2021

Ok, let's do what I said here: #27 (comment) and ignore "Remove pseudoelement for main page table"

Ok I will do what is said there!😊

@NAMANIND
Copy link

NAMANIND commented Dec 3, 2021

btw. this task is "paid" and if you send me an offer before doing it, you can receive payment in USDC. Process is here: https://github.com/rugpullindex/documents/blob/master/handbook.md#how-to-get-an-offer-approved-to-start-working-on-rpi

I don't know how to frame such proposal and you give me some idea or instance. And how much offer is ideal to demand for such work!? This is first of a kind "paid" contract so have such doubts :-l

@florianmodel
Copy link

The arrow should not appear in the table at all, only in text blocks (in the blog). Also no need to have it in the footer in my opinions, as it's clear those links are clickable.

@NAMANIND
Copy link

NAMANIND commented Dec 4, 2021

@florianmodel I will do whatever the updates you and @TimDaub wants . once he assign this work to me and give the answer of the above questions I asked about proposal and other things.

@NAMANIND
Copy link

Hey, can you please rply to my comments above.I really wanted to contribute here.

@TimDaub
Copy link
Member Author

TimDaub commented Dec 15, 2021

btw. this task is "paid" and if you send me an offer before doing it, you can receive payment in USDC. Process is here: https://github.com/rugpullindex/documents/blob/master/handbook.md#how-to-get-an-offer-approved-to-start-working-on-rpi

I don't know how to frame such proposal and you give me some idea or instance. And how much offer is ideal to demand for such work!? This is first of a kind "paid" contract so have such doubts :-l

You can text me in Discord to get further help. Or carefully read the handbook document. It outlines what information is necessary and where to send it.

@NAMANIND
Copy link

@TimDaub can you please provide discord channel link. I am unable to find it on this repo 🥺

@TimDaub
Copy link
Member Author

TimDaub commented Dec 15, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants