Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Stop mixing control-flow logic and upgrade code base to esm modules #29

Open
TimDaub opened this issue Dec 3, 2021 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@TimDaub
Copy link
Member

TimDaub commented Dec 3, 2021

Scope

  • index.js currently uses the .js extension, but to future proof it we want to use .mjs and convert all imports to esm-based ones
  • Additionally, control-flow logic, e.g. "async/await", "promises" and "callbacks" are currently mixed in index.js. But we want to consistently use "async/await"

Deliverables

  • Use "fs/promises" and don't use callbacks or ...Sync methods of fs
  • Use "async/await" everywhere

Note

For anything express related, using their standard callback logic is fine e.g. app.get(...,...)

@TimDaub TimDaub added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant