Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin-JVM support (protobuf >=3.17.0) #139

Open
Zetten opened this issue Sep 14, 2021 · 1 comment · May be fixed by #250
Open

Kotlin-JVM support (protobuf >=3.17.0) #139

Zetten opened this issue Sep 14, 2021 · 1 comment · May be fixed by #250
Labels
enhancement New feature or request plugin Regarding external plugins

Comments

@Zetten
Copy link

Zetten commented Sep 14, 2021

The upstream projects seem to have been working on adding support for Kotlin (at least Kotlin-JVM flavour): Protobuf in protobuf v3.17.0 and gRPC with grpc-kotlin v1.1.0.

Obviously in a pinch the Java libraries do the trick, but there are some nice integrations in the Kotlin-specific code, so it would be great if this support could be extended to these rules, once the baseline is updated.
@aaliddell aaliddell added enhancement New feature or request plugin Regarding external plugins labels Sep 14, 2021
@aaliddell
Copy link
Member

👍

It looks like all the pieces are there for this to work ok. I might need some help with the example code for the tests though, since I’ve never written a line of Kotlin before 🙂

@aaliddell aaliddell added this to the 4.0.0 milestone Sep 14, 2021
@aaliddell aaliddell mentioned this issue Sep 16, 2021
Merged
10 tasks
@aaliddell aaliddell removed this from the 4.0.0 milestone Sep 20, 2021
Zetten added a commit to Zetten/rules_proto_grpc that referenced this issue Feb 17, 2023
@Zetten
feat: Add Kotlin (JVM) support
c5ad74f 
Provide rules to build Kotlin proto and grpc libraries. Currently
upstream Protobuf and gRPC support only JVM-flavour Kotlin.

Fixes rules-proto-grpc#139.
Zetten added a commit to Zetten/rules_proto_grpc that referenced this issue Feb 17, 2023
@Zetten
feat: Add Kotlin (JVM) support
62a6f99 
Provide rules to build Kotlin proto and grpc libraries. Currently
upstream Protobuf and gRPC support only JVM-flavour Kotlin.

Fixes rules-proto-grpc#139.
Zetten added a commit to Zetten/rules_proto_grpc that referenced this issue Feb 17, 2023
@Zetten
feat: Add Kotlin (JVM) support
cd72ec4 
Provide rules to build Kotlin proto and grpc libraries. Currently
upstream Protobuf and gRPC support only JVM-flavour Kotlin.

Fixes rules-proto-grpc#139.
@Zetten Zetten linked a pull request Feb 17, 2023 that will close this issue
Open
Zetten added a commit to Zetten/rules_proto_grpc that referenced this issue May 5, 2023
@Zetten
feat: Add Kotlin (JVM) support
c2a110f 
Provide rules to build Kotlin proto and grpc libraries. Currently
upstream Protobuf and gRPC support only JVM-flavour Kotlin.

Fixes rules-proto-grpc#139.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request plugin Regarding external plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add Kotlin (JVM) support Zetten/rules_proto_grpc
2 participants
@Zetten @aaliddell