Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dependency to go_validate_library #149

Closed
ashwin153 opened this issue Sep 25, 2021 · 1 comment · Fixed by #152
Closed

Add missing dependency to go_validate_library #149

ashwin153 opened this issue Sep 25, 2021 · 1 comment · Fixed by #152
Labels
bug Something isn't working lang-go Go rules specific resolved-next-release Code to resolve issue is pending release

Comments

@ashwin153
Copy link

Issue Description

Currently, go_validate_library is missing a dependency on @com_github_envoyproxy_protoc-gen-validate//validate:go_default_library.

Log Output

No response

rules_proto_grpc Version

4.0.0

Bazel Version

4.1.0

OS

Ubuntu 20.04

Link to Demo Repo

No response

WORKSPACE Content

No response

BUILD Content

No response

Proto Content

No response

Any Other Content

No response
@ashwin153 ashwin153 added the bug Something isn't working label Sep 25, 2021
@aaliddell
Copy link
Member

Thanks. Weird that it successfully compiles without this. FYI the validator rules are possibly still in flux: #146

@aaliddell aaliddell added the lang-go Go rules specific label Sep 26, 2021
@aaliddell aaliddell mentioned this issue Oct 3, 2021
Merged
@aaliddell aaliddell added the resolved-next-release Code to resolve issue is pending release label Nov 28, 2021
aaliddell added a commit that referenced this issue Nov 28, 2021
@aaliddell
Add missing validate dep, closes #149
6860060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working lang-go Go rules specific resolved-next-release Code to resolve issue is pending release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4.1.0 Release rules-proto-grpc/rules_proto_grpc
2 participants
@ashwin153 @aaliddell