Compare bin subdirs of java home on root mismatch [fix 187] #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rattenkrieg
changed the title
Rattenkrieg
changed the title
|
Thank you for the contribution! |
runningcode
added a commit
that referenced
this pull request
Jan 18, 2023
|
Sorry, I reverted this here: #241 It doesn't work on my machine, see the revert for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187
We can take it further and resolve and compare other known java dirs ie
lib,jre. However I believebinis sufficient since this feature mostly cares about build reproducibility.Sadly I don't know a good way to test it since this feature is completely environment dependent, I'm happy to add such tests if anybody have an idea how to do it though.