Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat all terms of sort Bool as Predicate in "get-model" #3903

Open
geo2a opened this issue May 27, 2024 · 0 comments
Open

Treat all terms of sort Bool as Predicate in "get-model" #3903

geo2a opened this issue May 27, 2024 · 0 comments
Labels
booster Relates to booster code

Comments

@geo2a
Copy link
Collaborator

geo2a commented May 27, 2024

Currently, if we send a "get-model" request to kore-rpc-booster/booster-dev with a KoreJson term with e.g. ==Int:

{"format":"KORE","version":1,"term":{"tag":"App","name":"Lbl'UndsEqlsEqls'Int'Unds'","sorts":[],"args":[{"tag":"DV","sort":{"tag":"SortApp","name":"SortInt","args":[]},"value":"1"},{"tag":"DV","sort":{"tag":"SortApp","name":"SortInt","args":[]},"value":"1"}]}}

we will get the following warning:

[Warn#booster] get-model ignores supplied terms and only checks predicates

and an Unknwon response.

This happens because we only recognize a very limited class of terms as predicates.

In get-model requests, we should recognize all terns of sort Bool as predicates.

@geo2a geo2a added the booster Relates to booster code label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
booster Relates to booster code
Projects
None yet
Development

No branches or pull requests

1 participant