Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regressions on nom-8? #1822

Open
hadronized opened this issue Feb 8, 2025 · 2 comments
Open

Performance regressions on nom-8? #1822

hadronized opened this issue Feb 8, 2025 · 2 comments

Comments

@hadronized
Copy link
Contributor

Hello,

I’d rather post here because I’m not entirely sure whether the regression is genuine or if it’s just randomness. I have some data gathered via cargo bench and cargo benchcmp.

Let me know what you think

@marcdejonge
Copy link
Contributor

Can you come with a clean example when the performance has a clear regression? That would help to figure out why there is any regression. Some simple example parser that we can compare v7 and v8 on would be helpful.

@Geal
Copy link
Collaborator

Geal commented Feb 11, 2025

@marcdejonge I know @hadronized, we were already discussing off band. There's a benchmark output at https://paste.sr.ht/blob/03436c4cb74d9a9c058bb9cd5650ad9f27033222, and the benchmarking code is here https://git.sr.ht/~hadronized/glsl/tree/master/item/glsl/src/parse_benches.rs

I suspect nom is missing some inline tags in parts that would be easily inlined away by the compiler before

@hadronized hadronized changed the title Performance rgressions on nom-8? Performance regressions on nom-8? Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants