Switch to bitcoin's version of HKDF #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like that CI failure is coming from |
|
Yeah, so I am seeing |
* Our implementation of HKDF was pushed down into bitcoin, but has only been published in bitcoin_hashes, not in a new version of bitcoin yet. Once bitcoin is updated we can depend on the re-exported HKDF there.
nyonson
force-pushed
the
bitcoin-hashes
branch
from
cfe3d52
to
6421e2a
Compare
|
Nice. For future reference, I think re-exporting a crate on a new minor version also requires a minor version from |
|
ACK 6421e2a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our implementation of HKDF was pushed down into
bitcoin, but has only been published inbitcoin_hashesso far, not in a new version ofbitcoinyet. Oncebitcoinis updated we can depend on the re-exported HKDF there and drop thebitcoin_hashesdependency.