Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private_key_debug_is_obfuscated test is in the wrong crate #3186

Closed
Kixunil opened this issue Aug 19, 2024 · 7 comments
Closed

private_key_debug_is_obfuscated test is in the wrong crate #3186

Kixunil opened this issue Aug 19, 2024 · 7 comments
Labels
good first issue Tests

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Aug 19, 2024 •
edited
Loading

This test belongs to secp256k1, not bitcoin. The current situation is fragile and annoying.
@tcharding
Copy link
Member

We can probably delete the tests if rust-bitcoin/rust-secp256k1#722 merges.

@mahmudsudo
Copy link

can i take on this issue ?

@diogocanut
Copy link
Contributor

We can probably delete the tests if rust-bitcoin/rust-secp256k1#722 merges.

It looks like the PR has been merged, so now it's just a matter of removing private_key_debug_is_obfuscated?

@diogocanut diogocanut mentioned this issue Oct 27, 2024
Merged
@apoelstra
Copy link
Member

Yep, let's do it.

apoelstra added a commit that referenced this issue Nov 1, 2024
@apoelstra
Merge #3517: Remove private_key_debug_is_obfuscated test
112d75e 
7bff725 Remove private_key_debug_is_obfuscated test (Diogo Canut)

Pull request description:

  Solves #3186.

ACKs for top commit:
  tcharding:
    ACK 7bff725
  apoelstra:
    ACK 7bff725; successfully ran local tests; sure

Tree-SHA512: 68dcdc476ada7960eb224dd456010bc36a302472b8a8b4d1ea3ab9c6981550d7677a98516331d5e5ef636be0cdc7208c45278d70c506e04d067b997758fd4bcf
@shinghim
Copy link
Contributor

Looks like this is can be closed - fixed by #3517

@tcharding
Copy link
Member

Thanks man, its rad that you notice these things.

@shinghim
Copy link
Contributor

shinghim commented Nov 15, 2024 •
edited
Loading

@tcharding It's a byproduct of me combing through issues for ones that I can help out on without too much hand holding/review iterations since I don't have much experience in this repo yet. Happy to help! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Kixunil @apoelstra @tcharding @diogocanut @shinghim @mahmudsudo