Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a name with less dashes #48

Open
casey opened this issue Nov 14, 2024 · 10 comments
Open

Use a name with less dashes #48

casey opened this issue Nov 14, 2024 · 10 comments

Comments

@casey
Copy link

casey commented Nov 14, 2024

rust-bitcoincore-rpc has always been a pretty painful name, given that it's four words with two dashes. This crate has three dashes, which feels like a lot. Also, it's not very obvious what the difference is between rust-bitcoincore-rpc and rust-bitcoind-json-rpc.

I think it might be worth considering using a more compact name which is easier to remember, distinguish, and type.

May I suggest corepc as short for "Bitcoin Core RPC"?

@tcharding
Copy link
Member

corepc - I like it. I also get annoyed at the current names. Though this repo provides three crates, we'd need names for all of them. Currently

  • bitcoind-json-rpc-client
  • bitcoind-json-rpc-types
  • bitcoind-json-rpc-regtest

They could become

  • corepc
  • corepc-types
  • bitcoind-json-rpc-regtest (dunno about this one, Ricardo's original bitcoind name is the best)

@casey
Copy link
Author

casey commented Nov 14, 2024

corepc and corepc-types both sound great. Maybe corepc-node or corepc-test?

@tcharding
Copy link
Member

Nice corerpc-node, be careful, if you keep this up you will become my go to guy for naming things.

@tcharding
Copy link
Member

I should have the whole v17 API done soon enough, when I release that I'll use the new names. Thanks bro.

@casey
Copy link
Author

casey commented Nov 14, 2024

Any time! I love making up names ^_^

@tcharding
Copy link
Member

You got me excited: https://crates.io/search?q=corepc

I did it in my github account https://github.com/tcharding/corepc

Will need input from @apoelstra before I go messing with github.com/rust-bitcoin/rust-bitcoind-json-rpc repo.

@apoelstra
Copy link
Member

Go for it!

@tcharding
Copy link
Member

tcharding commented Nov 14, 2024

Can you create a corepc repository under github.com/rust-bitcoin please bro. (I tried to transfer but don't have perms to create repos in that org.) Then I think I can do the transfer.

FTR, my plan:

  • transfer
  • Update the repository field in all 3 manifest
  • Cut 0.4.1 releases
  • Manually migrate issues
  • Migrate open PRs?
  • PR to rust-bitcoind-json-rpc README saying 'archiving because yada yada'
  • Archive rust-bitcoind-json-rpc

@apoelstra
Copy link
Member

@tcharding
Copy link
Member

I'm a bit nervous from the mistake I made described in #49. I'll do the move when I gather up the courage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants