Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: add sign_schnorr_no_aux_rand method for Keypair #761

Open
witter-deland opened this issue Nov 3, 2024 · 3 comments
Open

Feature request: add sign_schnorr_no_aux_rand method for Keypair #761

witter-deland opened this issue Nov 3, 2024 · 3 comments

Comments

@witter-deland
Copy link
Contributor

witter-deland commented Nov 3, 2024 •
edited
Loading

kaspanet/rusty-kaspa#586
@witter-deland witter-deland mentioned this issue Nov 3, 2024
Merged
@witter-deland witter-deland changed the title feature request: add sign_schnorr_no_aux_rand method for Keypair Feature request: add sign_schnorr_no_aux_rand method for Keypair Nov 3, 2024
@apoelstra
Copy link
Member

Are you aware of https://docs.rs/secp256k1/latest/secp256k1/struct.Secp256k1.html#method.sign_schnorr_no_aux_rand ?

apoelstra added a commit that referenced this issue Nov 3, 2024
@apoelstra
Merge #762: feat: add sign_schnorr_no_aux_rand for Keypair
2bfda46 
2d29116 feat: add sign_schnorr_no_aux_rand for Keypair (Witter)

Pull request description:

  #761
  kaspanet/rusty-kaspa#586

ACKs for top commit:
  apoelstra:
    ACK 2d29116; successfully ran local tests; thanks for iterating!

Tree-SHA512: 29556e315a2f046cb845bc625686ffa3151feee66e988912d026dcc994eb13b567063c246e4aa4e37f057fa01a94cd18443cb3fc1fd80f470ad34e59f6fe600f
@witter-deland
Copy link
Contributor Author

Is this a security issue? If so, it seems that sign_schnorr_no_aux_rand should not be made available to the public.
kaspanet/rusty-kaspa#587 (comment)

@apoelstra
Copy link
Member

No it is not a security issue.

@witter-deland witter-deland mentioned this issue Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apoelstra @witter-deland