Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide stream parser #4

Closed
Tracked by #5
epage opened this issue Jun 10, 2022 · 6 comments
Closed
Tracked by #5

Provide stream parser #4

epage opened this issue Jun 10, 2022 · 6 comments
Labels
C-enhancement Category: Raise on the bar on expectations

Comments

@epage
Copy link
Collaborator

epage commented Jun 10, 2022

This will be a building block for implicit conversions between formats
@epage epage added the C-enhancement Category: Raise on the bar on expectations label Jun 10, 2022
@epage
Copy link
Collaborator Author

epage commented Jun 10, 2022 •
edited
Loading

See

@epage epage mentioned this issue Dec 17, 2022
Closed
2 tasks
@Calder-Ty Calder-Ty mentioned this issue Dec 21, 2022
Closed
@epage
Copy link
Collaborator Author

epage commented Dec 22, 2022 •
edited
Loading

Just came across anes, cansi, and ansitok

@Calder-Ty Calder-Ty mentioned this issue Jan 4, 2023
Merged
@Calder-Ty
Copy link
Contributor

cansi looks like just what is needed, but unfortunately does not support truecolors.

@epage
Copy link
Collaborator Author

epage commented Jan 10, 2023

@Calder-Ty For roff's sake, that shouldn't matter as the initial version will more be a prototype for the sake of unblocking clap_mangen. We can always iterate on it further, extending what is supported, replacing the parser if needed, etc.

@epage epage mentioned this issue Jan 13, 2023
Closed
2 tasks
@Calder-Ty
Copy link
Contributor

Leaving this here for future reference.

anstyle-roff provides a limited private implementation of a stream parser. I think next steps for this would be to find a better library than cansi for doing our parsing, as it doesn't support true colors or xterm colors. (Or push changes for cansi upstream). vte as you mentioned looks very promising, but would require more work on our part.

@epage epage mentioned this issue Mar 2, 2023
Merged
epage added a commit that referenced this issue Mar 2, 2023
@epage
feat(parse): Kickstart with vtes code base
3cc5092 
In #4, I researched different libs I could use for this but none fit the
bill.  I approached `vte` about making changes to fit our needs but it
didn't seem like there was interest
(alacritty/vte#82), so instead we are using it
as the base for what we need.
@epage epage mentioned this issue Mar 2, 2023
Merged
epage added a commit that referenced this issue Mar 2, 2023
@epage
feat(parse): Kickstart with vtes code base
7058d0b 
In #4, I researched different libs I could use for this but none fit the
bill.  I approached `vte` about making changes to fit our needs but it
didn't seem like there was interest
(alacritty/vte#82), so instead we are using it
as the base for what we need.
This was referenced Mar 6, 2023
Merged
Merged
Open
@epage
Copy link
Collaborator Author

epage commented Mar 10, 2023

With #41 and other PRs, we now have a parser.

I split updating anstyle-roff out into #63.

@epage epage closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: Raise on the bar on expectations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epage @Calder-Ty