Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch anstyle-roff to anstyle-parse #63

Open
epage opened this issue Mar 10, 2023 · 2 comments
Open

Switch anstyle-roff to anstyle-parse #63

epage opened this issue Mar 10, 2023 · 2 comments
Labels
A-style Area: anstyle C-enhancement Category: Raise on the bar on expectations

Comments

@epage
Copy link
Collaborator

epage commented Mar 10, 2023

With #4, we can now use our own parser. We might need to reuse some code from anstyle-stream to do so.

@epage epage added the C-enhancement Category: Raise on the bar on expectations label Mar 10, 2023
@Calder-Ty
Copy link
Contributor

Hey I saw this, and saw the work you did forking vte. With the transfer of the
Roff style code were you thinking of a general purpose bytes or str to anstyle or just
implement one for the roff crate for now?

@epage
Copy link
Collaborator Author

epage commented Mar 11, 2023

Yes, I think it could make sense to make the conversion generic since roff will likely need everything that an anstyle parser would need.

anstyle-stream has a subset of bytes to anstyle used, just enough to get wincon working. That could be generalized. I lean towards that living in anstyle_parse or anstyle_stream. No preference yet on which of those it should be in.

This also isn't the most critical of things; I just didn't want to lose track of this.

@epage epage added the A-style Area: anstyle label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-style Area: anstyle C-enhancement Category: Raise on the bar on expectations
Projects
None yet
Development

No branches or pull requests

2 participants