Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal/vertical flip #47

Open
jamwaffles opened this issue Apr 8, 2018 · 5 comments
Open

Horizontal/vertical flip #47

jamwaffles opened this issue Apr 8, 2018 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jamwaffles
Copy link
Collaborator

On top of rotations a display mirror/flip should also be settable. I propose adding a DisplayFlip trait that allows opt-in flipping both horizontally and vertically.

@jamwaffles jamwaffles added enhancement New feature or request good first issue Good for newcomers labels Apr 8, 2018
@mjadczak
Copy link
Contributor

Seems like this could be implemented very cheaply by letting the display chip do it: the A0h/A1h "segment re-map" commands seem to do exactly this.

@jamwaffles
Copy link
Collaborator Author

Most likely! The rotation options use segment remap with another option to make the display do the rotation itself. Implementing display flip should be pretty simple using one option or the other for horizontal/vertical flip.

@mjadczak
Copy link
Contributor

On my ssd1306 chip at least (just a cheap one from AliExpress), the current Rotate90 and Rotate270 options actually flip the display horizontally (Rotate180 does actually rotate it, Rotate270 rotates 180º and then horizontally flips):

IMG_3526

@jamwaffles
Copy link
Collaborator Author

Just to clarify, the rotation behaviour is only broken in TerminalMode. GraphicsMode works as expected.

@jamwaffles
Copy link
Collaborator Author

TerminalMode rotation bug moved to #85. This issue will remain open as a tracker for the original flip feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants