Fulfillment of the I2c trait contract #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastevens
requested changes
May 7, 2024
nastevens
reviewed
May 7, 2024
nastevens
previously approved these changes
May 7, 2024
|
Looks good now! Thanks for your efforts! |
nastevens
reviewed
May 7, 2024
Co-authored-by: Nick Stevens <[email protected]>
nastevens
previously approved these changes
May 7, 2024
|
Sorry, now rustfmt is unhappy 😮💨 |
nastevens
approved these changes
May 8, 2024
|
Thanks again @ohunter, sorry it took a few tries to get things merged! |
|
No worries. I'm just happy to contribute 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seeks to address the issue with the
LinuxI2CDevicenot correctly implementing the I2c trait as mentioned in rust-embedded/linux-embedded-hal#82. I am not sure whether the fix really belongs in this repo but sincei2c_msg.flagsisn't pub then it doesn't seem like there is another way. Setting the flag when the device doesn't implement the feature seems to have no effect which might lead to some confusion.