wip

Author: syphar

src/db/types.rs

@@ -37,3 +37,9 @@ impl BuildStatus {
         matches!(self, BuildStatus::Success)
     }
 }
+
+impl sqlx::postgres::PgHasArrayType for BuildStatus {
+    fn array_type_info() -> sqlx::postgres::PgTypeInfo {
+        sqlx::postgres::PgTypeInfo::with_name("_build_status")
+    }
+}

src/web/crate_details.rs

@@ -90,6 +90,16 @@ where
 pub(crate) struct Release {
     pub id: i32,
     pub version: semver::Version,
+    /// Aggregated build status of the release.
+    /// * no builds -> build In progress
+    /// * any build is successful -> Success
+    ///   -> even with failed or in-progress builds we have docs to show
+    /// * any build is failed -> Failure
+    ///   -> we can only have Failure or InProgress here, so the Failure is the
+    ///      important part on this aggregation level.
+    /// * the rest is all builds are in-progress -> InProgress
+    ///   -> if we have any builds, and the previous conditions don't match, we end
+    ///      up here, but we still check.
     pub build_status: BuildStatus,
     pub yanked: bool,
     pub is_library: bool,
@@ -352,46 +362,60 @@ pub(crate) async fn releases_for_crate(
         r#"SELECT
              releases.id,
              releases.version,
-             COALESCE(builds.build_status, 'failure') as "build_status!: BuildStatus",
+             (
+                 SELECT ARRAY_AGG(builds.build_status ORDER BY builds.id)
+                 FROM builds
+                 WHERE builds.rid = releases.id
+             ) as "build_status?: Vec<BuildStatus>",
              releases.yanked,
              releases.is_library,
              releases.rustdoc_status,
              releases.target_name
          FROM releases
-         LEFT JOIN LATERAL (
-            SELECT build_status FROM builds
-            WHERE builds.rid = releases.id
-            ORDER BY builds.build_time
-            DESC LIMIT 1
-         ) AS builds ON true
          WHERE
              releases.crate_id = $1"#,
         crate_id,
     )
     .fetch(&mut *conn)
     .try_filter_map(|row| async move {
-        Ok(
-            match semver::Version::parse(&row.version).with_context(|| {
-                format!(
-                    "invalid semver in database for crate {crate_id}: {}",
-                    row.version
-                )
-            }) {
-                Ok(semversion) => Some(Release {
-                    id: row.id,
-                    version: semversion,
-                    build_status: row.build_status,
-                    yanked: row.yanked,
-                    is_library: row.is_library,
-                    rustdoc_status: row.rustdoc_status,
-                    target_name: row.target_name,
-                }),
-                Err(err) => {
-                    report_error(&err);
-                    None
-                }
-            },
-        )
+        let semversion = match semver::Version::parse(&row.version).with_context(|| {
+            format!(
+                "invalid semver in database for crate {crate_id}: {}",
+                row.version
+            )
+        }) {
+            Ok(semver) => semver,
+            Err(err) => {
+                report_error(&err);
+                return Ok(None);
+            }
+        };
+
+        Ok(Some(Release {
+            id: row.id,
+            version: semversion,
+            build_status: row
+                .build_status
+                .map(|build_status| {
+                    if build_status.contains(&BuildStatus::Success) {
+                        BuildStatus::Success
+                    } else if build_status.contains(&BuildStatus::Failure) {
+                        BuildStatus::Failure
+                    } else if build_status
+                        .iter()
+                        .all(|status| *status == BuildStatus::InProgress)
+                    {
+                        BuildStatus::InProgress
+                    } else {
+                        unreachable!()
+                    }
+                })
+                .unwrap_or(BuildStatus::InProgress),
+            yanked: row.yanked,
+            is_library: row.is_library,
+            rustdoc_status: row.rustdoc_status,
+            target_name: row.target_name,
+        }))
     })
     .try_collect()
     .await?;