update membership rules #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyler and I were reviewing these membership criteria and we felt that the wording could be improved.
nikomatsakis
commented
Oct 5, 2023
|
Looks like our github action is messed up :( |
RalfJung
reviewed
Oct 5, 2023
Co-authored-by: Ralf Jung <[email protected]>
nikomatsakis
commented
Oct 5, 2023
nikomatsakis
commented
Oct 5, 2023
tmandry
reviewed
Oct 5, 2023
tmandry
reviewed
Oct 5, 2023
Yeah, #221 |
Co-authored-by: Tyler Mandry <[email protected]>
per Tyler's suggestion
tmandry
approved these changes
Oct 6, 2023
|
Reviewing right now; these changes largely seem like improvements, though there are a few bits being removed that I'd like to preserve. |
joshtriplett
reviewed
Oct 7, 2023
joshtriplett
reviewed
Oct 7, 2023
joshtriplett
reviewed
Oct 7, 2023
joshtriplett
reviewed
Oct 7, 2023
joshtriplett
reviewed
Oct 7, 2023
joshtriplett
reviewed
Oct 7, 2023
Co-authored-by: Josh Triplett <[email protected]>
Co-authored-by: Josh Triplett <[email protected]>
Co-authored-by: Josh Triplett <[email protected]>
Co-authored-by: Josh Triplett <[email protected]>
Co-authored-by: Josh Triplett <[email protected]>
traviscross
reviewed
Oct 11, 2023
Co-authored-by: Travis Cross <[email protected]>
|
Going to take a chance and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tyler and I were reviewing these membership criteria and we felt that the wording could be improved.