android 32 bits fix stat struct proposal.

[devnexen]

close #3285

[rustbot]

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

[JohnTitor]

@bors r+

[bors]

📌 Commit 57bfcd8 has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit 57bfcd8 with merge 3fac855...

[bors]

💔 Test failed - checks-actions

[tgross35]

Looks like this doesn't agree with the libc we are checking against. I think @danielocfb was saying that we should use e.g. dev_t rather than c_ulong

@rustbot author

[tgross35]

@maurer would you mind looking at this? This would be a breaking change to stat for libc 1.0.

[maurer]

This change is incorrect - the bionic stat definition looks like the left hand side for 32-bit platforms.

I can comment over on the issue, but the reason this one is different is because the actual value returned here is not an ino_t. Even outside bionic (which you should use as the source of truth for what Android libc structures look like), 32-bit ARM musl has a similar header which makes the fact that this field is truncated more explicit.

It looks like there may be a couple places where using the "right type" is plausible (e.g. musl thinks that using dev_t for the first one could work), and I could talk to the bionic maintainer about making this switch if it would be helpful, but the proposed change would actually just flat out work incorrectly, the new proposed structure has the wrong offsets.