Skip to content

Make sure core library from sysroot is handled correctly #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lnicola opened this issue Feb 3, 2019 · 9 comments
Closed

Make sure core library from sysroot is handled correctly #731

lnicola opened this issue Feb 3, 2019 · 9 comments
Labels
E-has-instructions Issue has some instructions and pointers to code to get started E-medium

Comments

@lnicola
Copy link
Member

lnicola commented Feb 3, 2019

use std::time::Duration;

fn main() {
    Duration::<|>
}

The completion doesn't work in this case. Also, the tooltip says "Failed to exactly resolve the symbol".

@matklad
Copy link
Member

matklad commented Feb 3, 2019

most likely #523 or #231 (specifically, glob import support).

@lnicola
Copy link
Member Author

lnicola commented Feb 3, 2019

I don't think glob imports are involved, but std::time::Duration is a re-export from core::time. Do you think it's #523?

@matklad
Copy link
Member

matklad commented Feb 3, 2019

Yep, looks like it!

@lnicola
Copy link
Member Author

lnicola commented Feb 3, 2019

I can't find any extern crate rename, though.

@lnicola lnicola closed this as completed Feb 3, 2019
@matklad
Copy link
Member

matklad commented Feb 3, 2019

@matklad matklad changed the title Imports not resolved Make sure core library from sysroot is handled correctly Feb 3, 2019
@matklad matklad added E-medium E-has-instructions Issue has some instructions and pointers to code to get started labels Feb 3, 2019
@matklad
Copy link
Member

matklad commented Feb 3, 2019

Thinking about this more, this might actually be another issue, reopened with a more specific title.

@lnicola
Copy link
Member Author

lnicola commented Feb 3, 2019

Hmm, I tried the obvious thing (add core to STD_DEPS) and now it seems to resolve Duration, but not Duration::from_secs. Completion is still not working.

@lnicola lnicola reopened this Feb 3, 2019
@flodiebold
Copy link
Member

Completion or resolution of associated method calls is simply not implemented yet.

lnicola added a commit to lnicola/rust-analyzer that referenced this issue Feb 3, 2019
bors bot added a commit that referenced this issue Feb 3, 2019
732: Add core to STD_DEPS r=matklad a=lnicola

See #731.

Co-authored-by: Laurențiu Nicola <[email protected]>
@lnicola
Copy link
Member Author

lnicola commented Feb 3, 2019

The associated method limitation seems pretty big, should we open an issue for it?

@bors bors bot closed this as completed in #732 Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-has-instructions Issue has some instructions and pointers to code to get started E-medium
Projects
None yet
Development

No branches or pull requests

3 participants