Skip to content

Commit 809ef24

Browse files
committed
print omitted frames count for short backtrace mode
1 parent 571c9fc commit 809ef24

File tree

5 files changed

+24
-2
lines changed

5 files changed

+24
-2
lines changed

library/std/src/sys_common/backtrace.rs

+19
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ unsafe fn _print_fmt(fmt: &mut fmt::Formatter<'_>, print_fmt: PrintFmt) -> fmt::
6060
bt_fmt.add_context()?;
6161
let mut idx = 0;
6262
let mut res = Ok(());
63+
let mut omitted_count: usize = 0;
64+
let mut first_omit = true;
6365
// Start immediately if we're not using a short backtrace.
6466
let mut start = print_fmt != PrintFmt::Short;
6567
backtrace_rs::trace_unsynchronized(|frame| {
@@ -85,10 +87,27 @@ unsafe fn _print_fmt(fmt: &mut fmt::Formatter<'_>, print_fmt: PrintFmt) -> fmt::
8587
start = true;
8688
return;
8789
}
90+
if !start {
91+
omitted_count += 1;
92+
}
8893
}
8994
}
9095

9196
if start {
97+
if omitted_count > 0 {
98+
debug_assert!(print_fmt == PrintFmt::Short);
99+
// only print the message between the middle of frames
100+
if !first_omit {
101+
let _ = writeln!(
102+
bt_fmt.formatter(),
103+
" [... omitted {} frame{} ...]",
104+
omitted_count,
105+
if omitted_count > 1 { "s" } else { "" }
106+
);
107+
}
108+
first_omit = false;
109+
omitted_count = 0;
110+
}
92111
res = bt_fmt.frame().symbol(frame, symbol);
93112
}
94113
});

src/tools/build-manifest/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ toml = "0.5"
88
serde = { version = "1.0", features = ["derive"] }
99
serde_json = "1.0"
1010
anyhow = "1.0.32"
11-
flate2 = "1.0.16"
11+
flate2 = "1.0.26"
1212
xz2 = "0.1.7"
1313
tar = "0.4.29"
1414
sha2 = "0.10.1"

tests/ui/consts/const-eval/const-eval-query-stack.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
// normalize-stderr-test "\s\d{1,}: .*\n" -> ""
1111
// normalize-stderr-test "\s at .*\n" -> ""
1212
// normalize-stderr-test ".*note: Some details.*\n" -> ""
13-
13+
// normalize-stderr-test ".*omitted \d{1,} frames.*\n" -> ""
1414
#![allow(unconditional_panic)]
1515

1616
const X: i32 = 1 / 0; //~ERROR constant

tests/ui/panics/short-ice-remove-middle-frames-2.run.stderr

+2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@ stack backtrace:
33
0: std::panicking::begin_panic
44
1: short_ice_remove_middle_frames_2::eight
55
2: short_ice_remove_middle_frames_2::seven::{{closure}}
6+
[... omitted 3 frames ...]
67
3: short_ice_remove_middle_frames_2::fifth
78
4: short_ice_remove_middle_frames_2::fourth::{{closure}}
9+
[... omitted 4 frames ...]
810
5: short_ice_remove_middle_frames_2::first
911
6: short_ice_remove_middle_frames_2::main
1012
7: core::ops::function::FnOnce::call_once

tests/ui/panics/short-ice-remove-middle-frames.run.stderr

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ stack backtrace:
44
1: short_ice_remove_middle_frames::seven
55
2: short_ice_remove_middle_frames::sixth
66
3: short_ice_remove_middle_frames::fifth::{{closure}}
7+
[... omitted 4 frames ...]
78
4: short_ice_remove_middle_frames::second
89
5: short_ice_remove_middle_frames::first::{{closure}}
910
6: short_ice_remove_middle_frames::first

0 commit comments

Comments
 (0)