Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE when multiple supertrait substitutions need assoc but only one is provided #133392

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ICE when multiple supertrait substitutions need assoc but only one is provided #133392

wants to merge 2 commits into from

Conversation

compiler-errors
Copy link
Member

I'll write more here when the crate run is done.

Fixes #133388

r? lcnr
@rustbot author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 23, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2024

changes to the core type system

cc @compiler-errors, @lcnr

HIR ty lowering was modified

cc @fmease

@compiler-errors
Copy link
Member Author

@bors try

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 23, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 23, 2024
@bors
Auto merge of rust-lang#133392 - compiler-errors:object-sup, r=<try>
c7377f6 
Fix ICE when multiple supertrait substitutions need assoc but only one is provided

I'll write more here when the crate run is done.

Fixes rust-lang#133388

r? lcnr
`@rustbot` author
@bors
Copy link
Contributor

bors commented Nov 23, 2024

⌛ Trying commit 8a10f68 with merge c7377f6...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 23, 2024

☀️ Try build successful - checks-actions
Build commit: c7377f6 (c7377f633f2c785ef968ab6517e5218297777ae5)

@compiler-errors
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-133392 created and queued.
🤖 Automatically detected try build c7377f6
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-crater Status: Waiting on a crater run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for dyn providing all of its projections is incomplete w.r.t. different supertrait substitutions
6 participants
@compiler-errors @rustbot @bors @rust-log-analyzer @craterbot @lcnr