Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap/compiletest: msys2 msys --skip filter behaves strangely #134226

Open
jieyouxu opened this issue Dec 12, 2024 · 1 comment
Open

bootstrap/compiletest: msys2 msys --skip filter behaves strangely #134226

jieyouxu opened this issue Dec 12, 2024 · 1 comment
Labels
A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) C-enhancement Category: An issue proposing an enhancement or a PR with one. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

As I suspected (unfortunately), inside MSYS2 MSYS, the --skip on the exact path does not work (I suspect this is a compiletest problem, not bootstrap). However, MSYS2 MSYS also has several other ./x test-related issues, so this is not worth blocking on MSYS2 problems IMO.

$ ./x test tests/ui/traits/fn-pointer/bare-fn-no-impl-fn-ptr-99875.rs --stage 1 --skip tests/ui/traits/fn-pointer/bare-fn-no-impl-fn-ptr-99875.rs

running 1 tests
.

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 18066 filtered out; finished in 97.23ms

Originally posted by @jieyouxu in #134209 (comment)

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 12, 2024
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 12, 2024
@ChrisDenton
Copy link
Member

ChrisDenton commented Dec 12, 2024

Hm, I didn't get the same result. I'm using the msys2 shell:

$ ./x test tests/ui/traits/fn-pointer/bare-fn-no-impl-fn-ptr-99875.rs --stage 1 --skip tests/ui/traits/fn-pointer/bare-fn-no-impl-fn-ptr-99875.rs
[...]

running 0 tests


test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 18067 filtered out; finished in 5.19ms

Build completed successfully in 0:00:09

Edit: oh that's after 724052f

On current master I need to do:

./x test tests/ui/traits/fn-pointer/bare-fn-no-impl-fn-ptr-99875.rs --stage 1 --skip 'tests\ui\traits\fn-pointer\bare-fn-no-impl-fn-ptr-99875.rs'

@jieyouxu jieyouxu added C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed C-bug Category: This is a bug. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) C-enhancement Category: An issue proposing an enhancement or a PR with one. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Development

No branches or pull requests

3 participants