Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #119286: show linker output even if the linker succeeds #135106

Closed
3 tasks
rustbot opened this issue Jan 4, 2025 · 3 comments
Closed
3 tasks
Labels
A-linkage Area: linking into static, shared libraries and binaries relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2025

This issue tracks the release notes text for #119286.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Compiler
- [Stop silencing linker warnings](https://github.com/rust-lang/rust/pull/119286)

  Previously, rustc would discard all output from the linker unless it exited with a non-success status code. Now it shows warnings and messages from the linker even if linking succeeds. Linker diagnostics can be controlled using the new `allow(linker_messages)` lint.

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @jyn514, @bjorn3 -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 4, 2025
@jieyouxu jieyouxu removed A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs labels Jan 5, 2025
@Noratrieb Noratrieb removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 6, 2025
@jyn514
Copy link
Member

jyn514 commented Jan 17, 2025

@rustbot label A-linkage

@rustbot rustbot added the A-linkage Area: linking into static, shared libraries and binaries label Jan 17, 2025
@jyn514
Copy link
Member

jyn514 commented Jan 17, 2025

I don't have edit permissions. Here's a draft note:

Previously, rustc would discard all output from the linker unless it exited with a non-success status code. Now it shows warnings and messages from the linker even if linking succeeds. Linker diagnostics can be controlled using the new allow(linker_messages) lint.

@rustbot rustbot added this to the 1.86.0 milestone Jan 25, 2025
@Urgau
Copy link
Member

Urgau commented Mar 24, 2025

This change was reverted in #136098. Closing this release note issue, as to not have it appear on the release notes.

@Urgau Urgau closed this as completed Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linkage Area: linking into static, shared libraries and binaries relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants