Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a Way to Silence change-id Warnings #138925

Closed
Shourya742 opened this issue Mar 25, 2025 · 5 comments · Fixed by #138986
Closed

Find a Way to Silence change-id Warnings #138925

Shourya742 opened this issue Mar 25, 2025 · 5 comments · Fixed by #138986
Assignees
@Shourya742
Labels
A-bootstrap-config Area: bootstrap `config.toml` and the config system T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Shourya742
Copy link
Contributor

Shourya742 commented Mar 25, 2025 •
edited by rustbot
Loading

The change-id field increases rapidly, and some users want to suppress the associated warnings. Implement a method to modify change-id to achieve this.
@Shourya742 Shourya742 added C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 25, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 25, 2025
@Shourya742
Copy link
Contributor Author

@rustbot claim

@jieyouxu jieyouxu added A-bootstrap-config Area: bootstrap `config.toml` and the config system and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 25, 2025
@Shourya742
Copy link
Contributor Author

Hello @jieyouxu, I have a couple of approaches for this. Let me know which you think is best or if you have a better suggestion:

  1. Set change_id = 0 as the default value to suppress warnings.
  2. Add a separate boolean flag to the config to suppress warnings (though adding an extra parameter just for suppression might feel like overkill).

Looking forward to your thoughts!

@onur-ozkan
Copy link
Member

We shouldn't silently change its default value. If you want to add a way to silence the change-id logs, you should consider this approach instead.

@onur-ozkan onur-ozkan removed the C-bug Category: This is a bug. label Mar 25, 2025
@jieyouxu
Copy link
Member

Yeah, it should be an explicit ignore and not change the default value.

@Shourya742
Copy link
Contributor Author

Ah! That means the change_id in the config needs to be changed to an enum to support both usize and a string literal, and I'll need to explicitly check for the ignore variant. Sounds good!

@Shourya742 Shourya742 mentioned this issue Mar 26, 2025
Merged
@bors bors closed this as completed in 60833b1 Mar 28, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 28, 2025
@rust-timer
Unrolled build for rust-lang#138986
ccebcd9 
Rollup merge of rust-lang#138986 - Shourya742:2025-03-25-add-ignore-to-change-id, r=Kobzol

feat(config): Add ChangeId enum for suppressing warnings

closes: rust-lang#138925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shourya742 Shourya742

Labels
A-bootstrap-config Area: bootstrap `config.toml` and the config system T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(config): Add ChangeId enum for suppressing warnings Shourya742/rust
4 participants
@jieyouxu @onur-ozkan @rustbot @Shourya742