Skip to content

Check if some //@ ignore-test auxiliaries can instead use the canonical auxiliary/ infra #139706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jieyouxu opened this issue Apr 12, 2025 · 1 comment
Closed

Check if some //@ ignore-test auxiliaries can instead use the canonical auxiliary/ infra #139706

jieyouxu opened this issue Apr 12, 2025 · 1 comment
Assignees
@jieyouxu
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

Some tests are //@ ignore-test because they are auxiliaries / support files, but they aren't placed under canonical auxiliary/ directories. Audit these files to see if they can instead use auxiliary/ infra without regressing test intention.
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 12, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 12, 2025
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 12, 2025
@jieyouxu jieyouxu self-assigned this Apr 12, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Apr 15, 2025 •
edited
Loading

Update: see #139783

I did another survey pass over //@ ignore-test under tests/, and this is the only 2 non-tests that should use compiletest-ignore-dir.

Other aux test support files have various reasons that they either can't use auxiliary/ directory (majority of cases) or moving aux file under auxiliary/ requires significant changes to the original test (incl. error annotations) that does not justify the churn.

See #t-compiler > Handling disabled `//@ ignore-test` tests @ 💬 for some more discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot