Skip to content

compiletest: consider rejecting conditional test execution directives being used together with unconditional test disabling directives #139970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jieyouxu opened this issue Apr 17, 2025 · 0 comments
Open

compiletest: consider rejecting conditional test execution directives being used together with unconditional test disabling directives #139970

jieyouxu opened this issue Apr 17, 2025 · 0 comments
Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Apr 17, 2025 •
edited
Loading

Remark: useless/misleading //@ run-pass in a few aux files that are //@ ignore-test (//@ ignore-auxiliary)

Originally posted by @jieyouxu in #139967 (comment)

Consider rejecting combination of

  • Conditional test execution directives (e.g. //@ ignore-*), with
  • Unconditional test execution directives (e.g. //@ ignore-test),

Since the unconditional test ignore will "absorb" conditional ones. Probably do this after reworking directive handling.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 17, 2025
@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 17, 2025
@jieyouxu jieyouxu changed the title compiletest: consider reject conditional test execution directives being used together with unconditional test disabling directives compiletest: consider rejecting conditional test execution directives being used together with unconditional test disabling directives Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot