Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #82232
This PR adds the
-Zmin-function-alignment=<align>
flag, that specifies a minimum alignment for all* functions.Motivation
This feature is requested by RfL here:
Behavior
The
fn_align
feature does not have an RFC. It was decided at the time that it would not be necessary, but maybe we feel differently about that now? In any case, here are the semantics of this flag:-Zmin-function-alignment=<align>
specifies the minimum alignment of all* functions#[repr(align(<align>))]
attribute can be used to override the function alignment on a per-function basis: when-Zmin-function-alignment
is specified, the attribute's value is only used when it is higher than the value passed to-Zmin-function-alignment
.2^29
: I checked a bunch of targets, and they all emit the.p2align 29
directive for targets that align functions at all (some GPU stuff does not have function alignment).*: Only with
build-std
would the minimum alignment also be applied tostd
functions.cc @ojeda
r? @workingjubilee you were active on the tracking issue