-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix types for ARM SIMD32 intrinsics #1679
Conversation
@Amanieu: no appropriate reviewer found, use |
These were previously defined using vector types which is incorrect. Instead, `{u}int{8x4,16x2}_t` are aliases for `i32` and `u32`. This also fixes CI since these types don't need to be passed in NEON registers and this was triggering a newly added compiler warning.
44f5a55
to
609906f
Compare
@heiher LoongArch seems to have been broken by rust-lang/rust#116558 as well, but I think the lint may be triggering incorrectly in that case? Perhaps this needs to be fixed on the compiler side? |
Sorry that should be @heiher. |
Thank you for pointing it out. I have created a PR for it: rust-lang/rust#133249 |
d9be2f1
to
89cd04e
Compare
cc @alexcrichton I've disabled WASM in CI because it was failing for the same reason as loongarch: the compiler is emitting an error because it thinks that SIMD types can't be passed as argument/return values when |
Thanks for the heads up! I'll take a look early next week into what the best fix would be |
Followed up with #1686 |
These were previously defined using vector types which is incorrect. Instead,
{u}int{8x4,16x2}_t
are aliases fori32
andu32
.This also fixes CI since these types don't need to be passed in NEON registers and this was triggering a newly added compiler warning.