Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users of IUI to specify ui-sys features build and fetch #60

Open
porky11 opened this issue Jan 15, 2019 · 4 comments
Open

Allow users of IUI to specify ui-sys features build and fetch #60

porky11 opened this issue Jan 15, 2019 · 4 comments
Labels
c-enhancement New feature or request k-buildprocess Issues with building the crate k-dependencies Issues with the crate's dependencies p-high High Priority
Milestone

Comments

@porky11
Copy link

porky11 commented Jan 15, 2019

Build and fetch failed for me to build, and since it's more common to install c libraries oneself before using in rust, these features should be disabled by default.

@NoraCodes NoraCodes added t-wontfix This will not be worked on k-dependencies Issues with the crate's dependencies k-buildprocess Issues with building the crate labels Feb 23, 2019
@NoraCodes
Copy link
Collaborator

since it's more common to install c libraries oneself before using in rust

Citation needed.

Specifically for libui, we're interested mostly in providing a smooth-as-possible experience for starting a project; while there are dependency issues to work out (CMake, platform libraries, etc), I think at the moment the best thing to do is to keep things the way they are, especially since we depend on a fairly arbitrary version of libui at the moment.

Thanks for bringing this to our attention, though!

@porky11
Copy link
Author

porky11 commented Feb 24, 2019

The main problem was, that I couldn't easily change the default features, since they were not changable in the more rusty iui wrapper

@NoraCodes
Copy link
Collaborator

This is a good point, and I'm sorry I misunderstood the problem originally. The answer is, I think, to propagate these features up to the IUI level.

@NoraCodes NoraCodes reopened this Feb 26, 2019
@NoraCodes NoraCodes added c-enhancement New feature or request p-high High Priority and removed t-wontfix This will not be worked on labels Feb 26, 2019
@NoraCodes NoraCodes changed the title Remove build and fetch form default features Allow users of IUI to specify ui-sys features build and fetch Feb 26, 2019
@NoraCodes NoraCodes added this to the 0.5 Release milestone Feb 26, 2019
@hedgehog1029
Copy link

Also running into this (edited) issue, it doesn't seem to be possible for me, a consumer of iui, to disable build & fetch via my cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-enhancement New feature or request k-buildprocess Issues with building the crate k-dependencies Issues with the crate's dependencies p-high High Priority
Projects
None yet
Development

No branches or pull requests

3 participants