snp network test fixes #1618
Merged
snp network test fixes #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kraxel
commented
Apr 10, 2025
•
kraxel
commented
- test/snp: NOT_STARTED error is not a test failure
- test/snp: UNSUPPORTED for statistics is not a test failure
- test/snp: drop multicast from packet filter.
- xtask/qemu: switch to virtio-net nic.
|
opened as draft as this series breaks aarch64 tests due to #1617 |
phip1611
reviewed
Apr 10, 2025
|
Switching from |
In case the network has not been started before (say by pxe test) the shutdown and stop functions may return NOT_STARTED. This is normal behavior and not a test failure. Signed-off-by: Gerd Hoffmann <[email protected]>
The edk2 virtio-net driver does not support statistics and returns UNSUPPORTED. This is correct behavior. Signed-off-by: Gerd Hoffmann <[email protected]>
The test case does not use multicast. The edk2 virtio-net driver does not support multicast. Drop it from packet filter. Signed-off-by: Gerd Hoffmann <[email protected]>
Use virtio-net instead of e1000. This gets network going on non-x86 platforms (aarch64, riscv64). While being at it switch qemu network configuration to modern netdev method. Signed-off-by: Gerd Hoffmann <[email protected]>
With the switch to virtio-net we have networking on all platforms. Turn on the pxe test everywhere. Also serves as workaround for rust-osdev#1617 Signed-off-by: Gerd Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.