Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment tag syntax #88

Open
imbolc opened this issue Jun 2, 2022 · 0 comments
Open

Comment tag syntax #88

imbolc opened this issue Jun 2, 2022 · 0 comments
Labels
Status: RFC Request for comments Type: Breaking Change Includes breaking changes

Comments

@imbolc
Copy link
Contributor

imbolc commented Jun 2, 2022

The issue with the current comment tag syntax is that it's hard to setup an editor to properly comment / uncomment a line. You can't just tell it to wrap the line into <%# ... %>. Because it will break when you try to comment another tag. E.g. <% } %> becomes <%# <% } %> %>, while it should be <%# <% } %> (first occurrence of %> closes the comment). For the same reason the current syntax is useless for block-wise commenting if the block includes any other tags.

Would you consider changing the closing comment tag to #%> or making it <# ... #>?
Another option would be explicitly making commens line-wise only, so first occurrence of <%# starts a comment which ends with the end of the line.

@Kogia-sima Kogia-sima added Type: Breaking Change Includes breaking changes Status: RFC Request for comments labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: RFC Request for comments Type: Breaking Change Includes breaking changes
Projects
None yet
Development

No branches or pull requests

2 participants