Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make program multithreaded and use less memory #31

Open
lolpro11 opened this issue Nov 27, 2023 · 2 comments
Open

Make program multithreaded and use less memory #31

lolpro11 opened this issue Nov 27, 2023 · 2 comments

Comments

@lolpro11
Copy link
Contributor

lolpro11 commented Nov 27, 2023

Use concurrent iterator for cycling through osm entries.
Use rolling buffer to drop data into file when X number of entries have been extracted.

@Tristramg
Copy link
Collaborator

Thank you for your interest.
This crate is rather in maintenance mode, so I can’t really say when I’ll have time to spend on this issue, especially given that your need some tricky performance optimization.

The --out is more straightforward. Could you make a separate issue to track it. Do you mean the output format, or the output files (that would require --edges-file and --nodes-file or something in that direction)

@lolpro11 lolpro11 changed the title Make program multithreaded and use less memory, add more cmd args Make program multithreaded and use less memory Nov 29, 2023
@Tristramg
Copy link
Collaborator

For the parallelization, with your implementation in #37 we have an ~30% performance improvement. A nice start.

For the memory usage, this is more difficult: we need to parse all the data to count how many times the nodes are used. Unfortunately, the way OSM data in built, there is no situation where we can be sure that partial data is complete and could be dumped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants