Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: FingerId may not be stable #3970

Open
madsmtm opened this issue Oct 25, 2024 · 0 comments
Open

iOS: FingerId may not be stable #3970

madsmtm opened this issue Oct 25, 2024 · 0 comments
Labels
B - bug Dang, that shouldn't have happened DS - ios

Comments

@madsmtm
Copy link
Member

madsmtm commented Oct 25, 2024

I think it may be prudent to use touch.hash() (importing NSObjectProtocol) instead of just converting to a pointer and comparing the address? I'm not entirely sure that the ID will be consistent otherwise, UITouch seems to be an immutable container that also contains e.g. the location of the current touch (so it'll probably change next time we process the specific touch).

Firefox' code seems to rely on inserting the UITouch into a hashmap, to store a stable identifier, so perhaps that's actually what we need to do?

Found while reviewing #3947.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened DS - ios
Development

No branches or pull requests

1 participant