This repository has been archived by the owner on Dec 29, 2023. It is now read-only.
WIP: Add support for Erlang 22 #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking this on. See slightly expanded test writing directions at https://github.com/rusterlium/erlang_nif-sys/wiki/Updating-this-package-for-new-OTP . Let me know if you need any more guidance. |
|
Thanks for instructions, will now try to actually implement tests. |
|
@goertzenator I added couple of test cases but not sure if they actually work as expected. |
|
Travis CI is showing errors on your code. Are they helping you move forward? |
|
@goertzenator I've been trying to fix them but at the moment unable to clearly understand what is needed. May be I need some help here. |
|
Hi guys! Is there any progress on this? |
|
@lessless @goertzenator sorry Im unable to dedicate time at least until september. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this PR tries to add missing definitions for Erlang 22 to resolve #37. At the moment I've been trying to figure out how to test since I'm quite new to Rust and Nifs as well. Any guidance and help will appreciated.
Thanks.