Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish a release with ring 0.17 #198

Closed
hoodie opened this issue Dec 8, 2023 · 2 comments
Closed

publish a release with ring 0.17 #198

hoodie opened this issue Dec 8, 2023 · 2 comments

Comments

@hoodie
Copy link

hoodie commented Dec 8, 2023

Hi there! Do you think it would be possible to make a release that includes the ring 0.17 update?

Ring 0.17 is considered a major release so rustc will include both 0.16 and 0.17 in a binary,
but since ring itself contains C-code this causes linker warnings on some platforms.

I've been trying to harmonize my dependencies to all use the same version of ring, and rcgen is the last one to not have a release with 0.17 yet. If you're holding our due to breaking changes, maybe 948c3b5 is a good candidate for a 0.11.4.

Thank you

@cpu
Copy link
Member

cpu commented Dec 8, 2023

👍 I think it makes sense to start deciding what needs to land before we cut a 0.12 release.

@cpu
Copy link
Member

cpu commented Dec 8, 2023

Let's track this in #199.

@cpu cpu closed this as completed Dec 8, 2023
@cpu cpu reopened this Dec 8, 2023
@cpu cpu closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants