-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all signature algorithms #60
Comments
The non-RSA based algos are blocked by ring support, while RSA based algos haven't been much of a priority for me because ring has no key generation support. I'm open to adding them though. |
I see. While there is no key generation support, we can at least load them from a file. |
I've tried adding RSA_PSS support in b2733e8 but didn't get it to work. So I made support non-pub for now. See also 46bf2ef . One could say it's blocked on briansmith/ring#1353 , but I'm not sure. I might try to build a remote KeyPair that can ingest openssl keys. Based on that I could build support for the remaining signature algorithms. |
I created a tool in go to generate certs signed with different algos: https://gist.github.com/kpp/c9c84411e17f4b27dddf0d438b289862#file-main-go with hardcoded |
Can't this be supported now, with the aws_lc_rs feature? If the support is still desired and currently possible, I could try to work on a PR to add the support. |
@Alvenix yeah, that probably makes sense. Would be great if you can submit a PR for this! |
See https://tools.ietf.org/id/draft-ietf-tls-tls13-21.html#rfc.section.4.2.3 for a full list of signature algos.
So far missing:
The text was updated successfully, but these errors were encountered: